Database Connection - Use environment variables (optional setting)

[M-arcus]

I am currently creating a Dockerfile for a selfhosted server-solution (cloudron). During first testing, I have encountered the following problem:

Problem

The MySQL credentials change at every start of the docker container, meaning the container only works at the first run. But the MySQL credentials can be accessed per getenv().

Proposed solution:

Add a config setting 'Get MySQL-Connection from Environment Variables'
Set the default false, so it doesn't break anything for existing installations.
If set to true, the credentials will be taken from the Environment Variables per getenv().

I would open a PR for it, if you agree to adding this feature

[MrPetovan]

This is similar to #4784, except that it concerns the install process, while your proposed solution would be bypassing the install for MySQL config, am I right?

[M-arcus]

Exactly, my solution would only bypass the MySQL part of the installation, since the values will be dynamic. Only an initial connection check would be needed.

[MrPetovan]

Here's my question then: do we need to choose between either implementation or can we have both at the same time?

[M-arcus]

It should be possible to use both at the same time, I would build my approach on top of #4784 's approach, as an extra checkbox/parameter during installation which activates either the "normal" or the "getenv" mode.

[MrPetovan]

Then by all mean, submit a PR.

[nupplaphil]

hm @M-arcus .. how do we sync changes from here and maybe #4784 to not break each other? How much is your progress so far? So shall I will wait with my approach/changes until you're finished?

[M-arcus]

Fixed by #4855

[M-arcus]

Documentation needed.
@MrPetovan Should I open a new issue for it?

[MrPetovan]

I just added the label, hopefully someone (maybe you?) will pick up on it.

[tobiasd]

@M-arcus could you write the docs for this?

[M-arcus]

@tobiasd yes, will do

[MrPetovan]

Thank you for your work!