Improved direction and protocol detection #9766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrPetovan
requested changes
Jan 10, 2021
src/Protocol/DFRN.php
Outdated
| @@ -2628,6 +2633,11 @@ public static function import($xml, $importer, $sort_by_date = false, $protocol | |||
| $header["wall"] = 0; | |||
| $header["origin"] = 0; | |||
| $header["contact-id"] = $importer["id"]; | |||
| $header["direction"] = $direction; | |||
|
|
|||
| if ($direction == Conversation::RELAY) { | |||
There was a problem hiding this comment.
Please use === when checking against a constant value.
There was a problem hiding this comment.
Why? Is it in some way faster?
There was a problem hiding this comment.
Since you're comparing constant values with constant values, you can be sure types won't be different. It's marginally faster but it's most importantly safer.
Merged
MrPetovan
approved these changes
Jan 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR funnily touches many files - but doesn't really do much - except some statistics :-) In an effort to better understand how messages arrive at Friendica we detect not only the transport protocol but also the direction (means if a posted had been pushed to our server or if we fetched it). This had been done before, but only partially and not for all protocols.
This is now done.
Also some unnecessary code and parameters concerning DFRN had been removed.