Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some root devDependencies to appropriate packages #194

Closed
fahad19 opened this issue May 13, 2017 · 0 comments
Closed

Move some root devDependencies to appropriate packages #194

fahad19 opened this issue May 13, 2017 · 0 comments
Assignees

Comments

@fahad19
Copy link
Member

fahad19 commented May 13, 2017

Since we use Lerna for managing our monorepo, we benefit by keeping majority of our common devDependencies in the root package.json.

Packages like Babel, ESLint, etc are all listed as devDependencies. Also also all site related packages (like metalsmith) are listed in root package.json too.

But there are also some, which are not common across all packages:

  • http-server (examples only)
  • jsdom (only frint-test-utils need it, iirc)
  • live-server (examples only)
  • react (only frint-react and frint-react-server should need it)
  • react-addons-test-utils (only frint-react and frint-react-server should need it)
  • react-dom (only frint-react and frint-react-server should need it)
  • rxjs

They should either be moved to appropriate packages as their own devDependencies, or removed altogether (because examples have their own package.json files now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant