Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add link to ZTF alerts on Source and Candidate pages #63

Closed
dannygoldstein opened this issue Oct 8, 2020 · 5 comments
Closed

add link to ZTF alerts on Source and Candidate pages #63

dannygoldstein opened this issue Oct 8, 2020 · 5 comments
Assignees

Comments

@dannygoldstein
Copy link
Member

@dmitryduev

I was about to open a pull request that overrode the source and candidate pages as Fritz extensions with a button that links to the ZTF alerts page. However, I realized that this would cause the Source and Candidates pages in fritz to fall out of sync with what is in SkyPortal. Any ideas on how to override componets that are already in Skyportal with Fritz specific features, but not have the two go out of sync?

Cc @stefanv

@dannygoldstein
Copy link
Member Author

dannygoldstein commented Oct 8, 2020

So basically, I was going to copy the current SourceDesktop.jsx into extensions/skyportal/... then add a ZTF Alerts button to it.

But I realized this file would soon become stale as it became updated with new features in skyportal/, so would require manual re-updating to stay current in fritz.

@stefanv
Copy link
Contributor

stefanv commented Oct 9, 2020

This is tricky; I don't see an easy workaround.

You could patch the files in fritz upon deploy, and as long as the patches remain relevant they will apply?

@kmshin1397
Copy link
Collaborator

@dannygoldstein Any further insights on this? I need to add ZTF alert links to the scanning page.

@dannygoldstein
Copy link
Member Author

This should now be possible with the new extensions plan for fritz

@dmitryduev
Copy link
Member

Implemented, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants