Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in decompression. #12

Closed
Frommi opened this issue Oct 24, 2017 · 3 comments
Closed

Bug in decompression. #12

Frommi opened this issue Oct 24, 2017 · 3 comments
Labels
bug

Comments

@Frommi
Copy link
Owner

Frommi commented Oct 24, 2017

Cargo built with miniz_oxide panics while unpacking clfft v0.3.1 package from crates.io. Found this bug using brand new tester.
@Frommi Frommi added the bug label Oct 24, 2017
@Frommi
Copy link
Owner Author

Frommi commented Oct 24, 2017 •
edited
Loading

Reproduction:

  • run cargo build in miniz_oxide_tester/cargo;
  • find cargo executable in target; run ./cargo new;
  • add clfft = "0.3.1" to deps in Cargo.toml of this new crate;
  • ./cargo build.

@oyvindln
Copy link
Collaborator

Oh wow, segmentation fault even.

@oyvindln
Copy link
Collaborator

I found the problem, though it's probably worth investigating why it triggered a segmentation fault after panicking.

Frommi pushed a commit that referenced this issue Jul 15, 2018
@oyvindln
Avoid out of bounds panic in inflate_fast + short bench.
bbd59b2 
One extra byte of ouput space was needed in inflate_fast for the current code. Should fix #12

Short benchmarks to compare startup times.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Frommi @oyvindln