Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy warning: literal bool comparison #71

Closed
danieleades opened this issue Oct 17, 2021 · 1 comment
Closed

clippy warning: literal bool comparison #71

danieleades opened this issue Oct 17, 2021 · 1 comment

Comments

@danieleades
Copy link

clippy complains if the return value is a boolean, since this results in a assert_eq!(expected_bool, actual_bool), which clippy was rather a assert!(actual_bool) or assert!(!actual_bool)

workaround is to add a #[allow(clippy::bool_assert_comparison)] to the test attributes. I think test-case should do that internally

@luke-biel
Copy link
Collaborator

luke-biel commented Oct 28, 2021

Workaround should be live on crates.io. Would be nice if you could verify it's fixed and close the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants