Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Adding Inner Icon option #10

Open
hobulian opened this issue Jan 5, 2022 · 4 comments
Open

[Feature request] Adding Inner Icon option #10

hobulian opened this issue Jan 5, 2022 · 4 comments
Labels
1_enhancement New feature or request

Comments

@hobulian
Copy link

hobulian commented Jan 5, 2022

Hope there be Inner icon option for Tiptac

like below.
https://imgur.com/a/LxLdLgW

I'm using this feature by my self-edited code

local newitt = "|T"..icon..":"..(cfg.if_iconSize - 16).."|t ".._G[self:GetName().."TextLeft1"]:GetText();
_G[self:GetName().."TextLeft1"]:SetText(newitt);
self:Show()

but hope it will supported officially.

@frozn
Copy link
Owner

frozn commented Jan 5, 2022

Seems like a good modifier option for "ItemRef->Show Icon Texture and Stack Count (when available)". I would like to add a dropdown menu for icon placement.

@hobulian
Copy link
Author

hobulian commented Jan 6, 2022

Seems like a good modifier option for "ItemRef->Show Icon Texture and Stack Count (when available)". I would like to add a dropdown menu for icon placement.

I couldn't applied this stuff to

"BattlePetTooltip"
"PetJournalPrimaryAbilityTooltip"
"PetJournalSecondaryAbilityTooltip"
"FloatingPetBattleAbilityTooltip"

Which doesn't have _G[self:GetName().."TextLeft1"] value but self.Name.

And also it has AbilityPetType mark inside so it's quite messy when with icons being inside tooltip.

I think it's needed that some other design for those frames or make those frames excluded from inner icon set.

@hobulian
Copy link
Author

hobulian commented Jan 6, 2022

In additions to that Icons on Item comparison tooltips are now not to be shown for some reason..

P.S I found it by adding
["ShoppingTooltip1"] = true,
["ShoppingTooltip2"] = true,
["ItemRefShoppingTooltip1"] = true,
["ItemRefShoppingTooltip2"] = true,
to tipsToAddIcon table

@frozn
Copy link
Owner

frozn commented Jan 15, 2022

Funny: I never noticed that because option "Show icons next to tooltips" in addon Pawn was checked and it adds the missing icons itself. 😅

Thanks for pointing this out. Added my changes to main-branch.

@frozn frozn added the 1_enhancement New feature or request label Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1_enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants