Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Adding some anchor point for icons #21

Closed
hobulian opened this issue Jan 14, 2022 · 5 comments
Closed

[Feature request] Adding some anchor point for icons #21

hobulian opened this issue Jan 14, 2022 · 5 comments
Labels
1_enhancement New feature or request 2_to develop Development can begin 3_solved Issue is fixed

Comments

@hobulian
Copy link

Now some points of tooltip cannot be anchored by tiptac option. I marked with circle in next SC
https://imgur.com/a/4ItCYfl

I think it's good to add x,y offset or relative anchor points into option.

@hobulian hobulian changed the title Adding some anchor point for icons [Feature request] Adding some anchor point for icons Jan 20, 2022
@frozn frozn added the 1_enhancement New feature or request label Jan 29, 2022
@frozn
Copy link
Owner

frozn commented Feb 6, 2022

@NoBetaBoredom has made a pull request to add this feature. It's already merged to the main branch. What do you think?

@frozn frozn added the 2_to develop Development can begin label Feb 6, 2022
@hobulian
Copy link
Author

hobulian commented Feb 7, 2022

Think it's working really nice. Can you do same things for raid icon/faction/combat/class icons?

@hobulian
Copy link
Author

hobulian commented Feb 7, 2022

This is not about icon anchors but in my client,
When backdrop border size is "1" then some times some borders seems to have value of "0" by relative points of screen.
https://imgur.com/a/c90WFHJ

After setted border size "1.5" this stopped happening.

@NoBetaBoredom
Copy link
Contributor

NoBetaBoredom commented Feb 7, 2022

Think it's working really nice. Can you do same things for raid icon/faction/combat/class icons?

I will check tomorrow, should be doable.

This is not about icon anchors but in my client, When backdrop border size is "1" then some times some borders seems to have value of "0" by relative points of screen. https://imgur.com/a/c90WFHJ

After setted border size "1.5" this stopped happening.

Borders are currently broken, I have already made a PR (#47 and #48) that makes the borders perfect (as far as I tested it). Hopefully @frozn will merge it!

@frozn
Copy link
Owner

frozn commented Feb 7, 2022

For adding anchor points for raid/faction/combat/class icons I created a new issue: #50

For the border issues, @NoBetaBoredom already created the PR #47 and #48. I really appreciate your input here! 👍

So, the issue with adding anchor points for ItemRef icons here is solved.

@frozn frozn closed this as completed Feb 7, 2022
@frozn frozn added the 3_solved Issue is fixed label Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1_enhancement New feature or request 2_to develop Development can begin 3_solved Issue is fixed
Projects
None yet
Development

No branches or pull requests

3 participants