Fix Files::clean and Directory::clean return to early if failing to find a tag
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 21, 2016 16:33
melloc01
changed the title
melloc01
changed the title
|
Hi @melloc01, hanks for pointing this out. Your fix make sense. Do you see that specific issue when running |
|
Sure @frqnck, will do! = ] |
|
Hi @melloc01, hope you are well. What is the status with your PR? Are you able to provide a test demonstrating the issue fixed by your PR? |
|
Hi @frqnck, I am, thanks, hope you are too : ] A big project started on the company, sorry about delaying it so much, will take a look at it on this weekend |
|
PR #24 implements tests to support this PR. Closing this one down. |
frqnck
changed the title
frqnck
changed the title
Files::clean and Directory::clean return to early if failing to find a tag
frqnck
added a commit
that referenced
this pull request
Oct 28, 2016
…to find a tag -- with supporting tests (#24) * Directory adapter to continue instead of returning when fails to find keys inside a tag * Directory & File adapters to try clean all tags instead of returning on the first empty tag * File Adapter@clean | fixing return value * Adds a regression tests for pull request GH#17 (#17)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directory adapter to continue trying to clean all tags instead of returning on the first miss