MongoDB - array serialisation of nested keys #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' in 'data.A.B' is not valid for storage."
4 similar comments
frqnck
changed the title
frqnck
added a commit
that referenced
this pull request
Oct 28, 2016
* mongodb: (25 commits) Prepping release 1.2.8 MongoDB - array serialisation of nested keys (#20) Allow HHVM and `mongodb` ext to fail under Travis Installing HHVM so we can compile mongo-hhvm-driver i i Added "sudo: required" as per http://stackoverflow.com/questions/26299552/travis-sudo-is-disabled [skip ci] Update README.md Test for hphpize test fix mongo-hhvm-driver Fix for HHVM Install for mongo-hhvm-driver Fix PHP 5.3 by using `arrav()` instead of `[]`. Test for an InvalidArgumentException Refactored Adds support got HHVM Adds MongoDB library More explicit skip message [skip ci] minor [skip ci] ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrays have to be serialized as well
After using mongo backend as a storage i came across an issue with arrays as data. When a key in associative array has dots, mongo throws exception:
MongoCursorException: localhost:27017: The dotted field 'A.B' in 'data.A.B' is not valid for storage.
Proposed fix
If input data is array it is serialized same way as in case of an object.
I also changed how serialized data is stored - there is a new property "serialized" which holds binary data. When data is fetched from the mongo we either de-serialize it, or use raw "data"