Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Files::clean and Directory::clean return to early if failing to find a tag -- with supporting tests #24

Merged
merged 4 commits into from
Oct 28, 2016
Merged

Fix Files::clean and Directory::clean return to early if failing to find a tag -- with supporting tests #24

merged 4 commits into from
Oct 28, 2016

Conversation

frqnck
Copy link
Member

@frqnck frqnck commented Oct 28, 2016 •
edited
Loading

What did you implement:

Implementing tests for PR#17

How can we verify it:

$ phpunit --group pr

Done and todos:

  • Write unit tests,
  • Write documentation,
  • Fix linting errors,
  • Make sure code coverage hasn't dropped,
  • Leave a comment that this is ready for review once you've finished the implementation.

@frqnck frqnck mentioned this pull request Oct 28, 2016
Closed
@frqnck frqnck changed the title Directory file adapters fix with tests Fix Files::clean and Directory::clean return to early if failing to find a tag -- with supporting tests Oct 28, 2016
@frqnck frqnck merged commit 25b7990 into master Oct 28, 2016
@frqnck frqnck deleted the directory-file-adapters-fix-with-tests branch October 28, 2016 17:45
@coveralls
Copy link

coveralls commented Oct 28, 2016 •
edited
Loading

Coverage Status

Changes Unknown when pulling f883c1d on directory-file-adapters-fix-with-tests into * on master*.

9 similar comments
@coveralls
Copy link

coveralls commented Oct 28, 2016 •
edited
Loading

Coverage Status

Changes Unknown when pulling f883c1d on directory-file-adapters-fix-with-tests into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f883c1d on directory-file-adapters-fix-with-tests into * on master*.

@coveralls
Copy link

coveralls commented Oct 28, 2016 •
edited
Loading

Coverage Status

Changes Unknown when pulling f883c1d on directory-file-adapters-fix-with-tests into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f883c1d on directory-file-adapters-fix-with-tests into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f883c1d on directory-file-adapters-fix-with-tests into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f883c1d on directory-file-adapters-fix-with-tests into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f883c1d on directory-file-adapters-fix-with-tests into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f883c1d on directory-file-adapters-fix-with-tests into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f883c1d on directory-file-adapters-fix-with-tests into * on master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frqnck @coveralls