update APCu #5
Closed
update APCu #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mimmi20 many thanks for the PR. Would you be kind enough to squash all your commits into one? Squash All Commits Related to a Single Issue into a Single Commit |
|
@mimmi20 I have squashed the commits for you. Many thanks for the great contribution -- and happy new year. |
|
@frqnck could you tell me when a branch should be squashed before opening a PR? |
|
@mimmi20 generally before opening a PR. For instance, if you create or modify a file there is no need to have dozens of commits from you branch polluting the master branch. It is a well documented and comon practice... |
|
@frqnck Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually the travis tests are failing caused by an update of apcu on PECL. I added the right versions to the install script to fix this.