Add memcache Adapter #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,6 +5,7 @@ sudo: false | |||
| services: | |||
| - redis-server | |||
| - memcached | |||
| - memcache | |||
There was a problem hiding this comment.
memcache is a PHP client to memcached. It is not a service/daemon -- memcached is the only service to use.
|
@mimmi20 these changes and additions should be split in different PRs, at least:
The general idea with a PR is to keep it short and concise so it is easy to review and merge. The goal is to avoid breaking existing code that depends on this package. Also, in your I am interested in some of the changes in |
|
Need to rework this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a Adapter to use
Memcache, for all Systems whereMemcachedis not available.I also fixed an Fatal Error for Memcached on HHVM and cleaned up the build for Travis a bit.
If the extra changes should get their own PR or this branch squased, plaese tell me.