Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL 1.1.1 #7

Closed
filom opened this issue Sep 17, 2018 · 10 comments
Closed

OpenSSL 1.1.1 #7

filom opened this issue Sep 17, 2018 · 10 comments

Comments

@filom
Copy link

filom commented Sep 17, 2018

I have issues compiling libssh for arm64, while armv7 is ok.

global.c:48:9: error: implicit declaration of function 'ENGINE_load_builtin_engines' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        libssh2_crypto_init();
        ^
../src/openssl.h:231:3: note: expanded from macro 'libssh2_crypto_init'

configuration:
Libssh2 version: 1.8.0 (Automatically detected)
OpenSSL version: 1.1.1 (Automatically detected)
SDK version: 11.4 (Automatically detected)

All right with OpenSSL 1.1.0i.
Any ideas ?

@noefroidevaux
Copy link

noefroidevaux commented Oct 1, 2018

I have the same problem (Libssh2 1.8.0, OpenSSL 1.1.1, iOS SDK 12.0), but it works with the previous version of OpenSSL ./iSSH2.sh -o1.1.0i

@jpalten
Copy link

jpalten commented Oct 9, 2018

same here...

@Frugghi
Copy link
Owner

Frugghi commented Oct 10, 2018

I'm not sure how to fix it, it seems that Libssh2 1.8.0 is not compatible with OpenSSL 1.1.1 or I'm not finding any flags/settings to make it working.

If you don't need OpenSSL 1.1.1, I'd follow @noefroidevaux suggestion to compile with OpenSSL 1.1.0i.

@yo-bur
Copy link

yo-bur commented Feb 14, 2019

It might be worth making a note of this in the readme or automatically choosing v1.1.0i

@manuelmuc
Copy link

You can use OpenSSL 1.1.1 with libssh2 master branch. You can download it from snapshots: https://www.libssh2.org/snapshots
Just modify iSSH2-libssh2.sh so that it takes the url from snapshot and use one snapshot version:
./iSSH2.sh -l 1.8.1-20190227

@HongliYu
Copy link

HongliYu commented Mar 20, 2019

./iSSH2.sh -o1.1.0i -l1.8.0 works for me

@Jan-E
Copy link
Contributor

Jan-E commented Mar 22, 2019

See Jan-E@6b2b61d for a fix. Read the comment below the commit as well.

@Jan-E
Copy link
Contributor

Jan-E commented Mar 28, 2019

FWIW: with the commit at Jan-E@6b2b61d updating to libssh2 1.8.2 with OpenSSL 1.1.1b was a breeze. Note the 'patching file src/openssl.h' after downloading libssh2:

TFRs-Mac:iSSH2 tfr$ ./iSSH2.sh --openssl=1.1.1b --libssh2=1.8.2
Initializing...

Libssh2 version: 1.8.2
OpenSSL version: 1.1.1b
SDK version: 12.2 (Automatically detected)
Architectures: armv7 armv7s arm64 x86_64
OS min version: 8.0

Downloading openssl-1.1.1b.tar.gz
######################################################################## 100.0%
MD5: 4532712e7bcc9414f5bce995e4e13930
Extracting openssl-1.1.1b.tar.gz
Building OpenSSL 1.1.1b, please wait...
- iPhoneOS armv7 done!
- iPhoneOS armv7s done!
- iPhoneOS arm64 done!
- iPhoneSimulator x86_64 done!
Building libssl.a fat library...
Building libcrypto.a fat library...
Copying headers...
Building done.
Downloading libssh2-1.8.2.tar.gz
######################################################################## 100.0%
MD5: 616efd99af3d9ef731a26bed6cee9593
Extracting libssh2-1.8.2.tar.gz
patching file src/openssl.h
Building Libssh2 1.8.2:
- iPhoneOS armv7 done!
- iPhoneOS armv7s done!
- iPhoneOS arm64 done!
- iPhoneSimulator x86_64 done!
Building libssh2.a fat library...
Copying headers...
Building done.
Cleaning up temporary files...
TFRs-Mac:iSSH2 tfr$ 

@Jan-E
Copy link
Contributor

Jan-E commented Jun 20, 2019

libssh2 1.9.0 was released. It compiles without additional testing.
Changelog: https://libssh2.org/changes.html#1.9.0

@filom
Copy link
Author

filom commented Jun 20, 2019

Build are smooth and without any issue:

Libssh2 version: 1.9.0 (Automatically detected)
OpenSSL version: 1.1.1c (Automatically detected)
SDK version: 12.2 (Automatically detected)
[..]
Building done.

@filom filom closed this as completed Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants