Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roundRect might be better as an extension to CanvasPath mixin #7

Closed
Kaiido opened this issue Aug 1, 2020 · 3 comments
Closed

roundRect might be better as an extension to CanvasPath mixin #7

Kaiido opened this issue Aug 1, 2020 · 3 comments

Comments

@Kaiido
Copy link

Kaiido commented Aug 1, 2020

The current proposal makes CanvasRoundRect about the same interface as CanvasRect, but I don't see the rationale for this choice.

As a web author I would prefer to have a roundRect() extension to the CanvasPath mixin, allowing to store it in Path2D objects maybe along with other shapes, or use it with methods like clip, isPointIn..., scrollToPath etc. and also allowing to fill or stroke many such shapes in a single call (with non negligible performance improvements).

I don't really see the point of having it outside of the "current path" and having an other method to clear pixels doesn't seem really useful either (we can already use compositing + fill() to clear from any path).

@fserb
Copy link
Owner

fserb commented Aug 3, 2020

cc @mysteryDate

@mysteryDate
Copy link
Collaborator

This seems totally reasonable to me. I'll see if there are objections on whatwg.

@Kaiido
Copy link
Author

Kaiido commented Feb 12, 2021

I believe #8 handled it, closing this.

@Kaiido Kaiido closed this as completed Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants