Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v2 API is so simplified I think it shouldn't be a huge maintenance burden to keep the definition in this repo.
Types are based on the types in the README, plus the missing
cloned
event from #286. Constants were copied from the header file.I'm unsure about the return type from
watch
. I based it onfsevents/fsevents.js
Lines 26 to 30 in e468f15
Promise
regardless ofinstance === null
or not? Happy to tweak that part of the code.EDIT: I've opened up a separate PR with the change to always return a Promise, and you can choose to accept that or not. I can tweak the type in this PR based on that conclusion: #296