feat: always return a promise from the stopper function #296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #295, the return value of the stopper function seems inconsistent. This makes it always return
Promise<null>
regardless of when it's called.An open question is - does
Native.stop
resolve with a value? I tested locally and it always resolved toundefined
, so I'm thinking just resolving tonull
is fine. But I don't know C, so it might resolve to something else in some cases?(I've also updated the readme with the new event from #286).