Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REUSE support in the GitHub licensee library #901

Open
ottok opened this issue Jan 26, 2024 · 5 comments
Open

Add REUSE support in the GitHub licensee library #901

ottok opened this issue Jan 26, 2024 · 5 comments
Labels
upstream It's someone else's problem

Comments

@ottok
Copy link

ottok commented Jan 26, 2024

Currently it seems that the GitHub licensee Ruby library they use for detecting licenses does not read the path LICENSES/. People hosting their code on GitHub probably value having GitHub detect their license correctly. Thus it might help drive adoption if the licensee matchers at https://github.com/licensee/licensee/tree/main/lib/licensee/matchers were extended to read the places REUSE recommends developers to use.

I am posting this for visibility while I am fully aware that this is not a bug in the reuse-tool itself.

@Mikaela
Copy link
Contributor

Mikaela commented Jan 26, 2024

licensee/licensee#635 looks like a related issue on their side although it's only about SPDX identifiers rather than the LICENSES/ directory.

@mxmehl mxmehl added the upstream It's someone else's problem label Jan 29, 2024
@mxmehl
Copy link
Member

mxmehl commented Jan 29, 2024

There have been a number of upstream issues about this already, and also discussions via Twitter IIRC. Mike Linksvayer has made it quite clear that they only implement this when a pull request is made by a third party.

The REUSE team doesn't currently plan to do that but we welcome any initiative!

@sdavids
Copy link

sdavids commented Apr 17, 2024

Mike Linksvayer has made it quite clear that they only implement this when a pull request is made by a third party.

The PR should target which repo?

https://github.com/licensee/licensee ?

@nicorikken
Copy link
Member

Indeed, unless GitHub has changes libraries in the mean time, but I wouldn't think so. Regardless, it would be good to have it in this commonly used library.

@carmenbianca
Copy link
Member

Linking the relevant licensee issue here: licensee/licensee#490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream It's someone else's problem
Projects
None yet
Development

No branches or pull requests

6 participants