FscHelper: separate fsc function with exit code, &c.
#491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yawaramin
changed the title
fsc function with exit code, &c.
| /// ... }) | ||
| let Fsc (fscParamSetter: FscParams -> FscParams) = | ||
| fsc fscParamSetter >> ignore |
There was a problem hiding this comment.
Please do not use partial application in public functions. It hides parameter names in VS and this makes it harder for users - especially when coming from C#. Please name all parameters.
Instead of piping to ignore we should throw a meaningful error.
This commit contains several small-ish changes. In order of appearance:
- Use an `FscParams.Default` static member instead of a free variable,
to express the tight coupling of the defaults with the type itself.
- Print compile errors and warnings with the appropriate `trace...`
functions.
- Return an exit code from the `fsc` function as I intend to use it to
help implement incremental build logic. The `Fsc` function
(uppercase 'F') still doesn't return anything so it can continue to
be used in the existing framework.
The `Fsc` call syntax looks very similar to what was originally proposed
in #235.
|
Thanks! Appreciate the feedback. I've done as you suggested--have made all parameters explicit and raised an exception. I guess this means I'll also have to redo several functions that I've come up with for my incremental build DSL :-) |
|
I learned that the hard way. If you look at old versions of FAKE you will find partial application and >> everywhere ;-) |
forki
added a commit
that referenced
this pull request
Jul 4, 2014
FscHelper: separate `fsc` function with exit code, &c.
|
thanks |
|
released with 3.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FscHelper: separate
fscfunction with exit code, &c.This commit contains several small-ish changes. In order of appearance:
FscParams.Defaultstatic member instead of a free variable,to express the tight coupling of the defaults with the type itself.
trace...functions.
fscfunction as I intend to use it tohelp implement incremental build logic. The
Fscfunction(uppercase 'F') still doesn't return anything so it can continue to
be used in the existing framework.
The
Fsccall syntax looks very similar to what was originally proposedin #235.