-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SemVerHelper #848
Fix SemVerHelper #848
Conversation
Update:
As mentioned in chat i do not know why the when_parsing_many_pre_release_versions test fails, as it is not comprehensible to me. Imho the expectations are not correct. |
will look into this on monday. thx a lot |
@forki as mentioned in chat i would be willing to finish this PR when its clear how to proceed :) the helper still includes a small issue i will fix on tuesday. |
Can you try to send the PR on top of my matthid:coreclr branch? This would make sure your changes are not lost in the new netcore release (and you could use them right away from the AppVeyor nuget feed (https://ci.appveyor.com/nuget/fake). If you need help, let me know. Thanks! |
There is also another problem with this. nuget.org is still slowly migrating to semver v2 and this change might break users of nuget packages published with FAKE... However I still think this is the correct fix. We probably apply this and look where things break... |
This probably needs some re-basing. Note that I would be much more comfortable with adding this to the new |
Leaving open because of the reported bug. |
I applied this patch to |
Fix for #847