Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSharp.Compiler.Services should tolerate an FSharp.Core without siginfo/optdata in the search path #38

Closed
sergey-tihon opened this issue Jan 24, 2014 · 7 comments

Comments

@sergey-tihon
Copy link
Contributor

fsprojects/ProjectScaffold#46

@ghost
Copy link

ghost commented Mar 10, 2014

@sergey-tihon could you add steps for a minimal repro for this?

@sergey-tihon
Copy link
Contributor Author

I know only one way to reproduce this:

  1. Checkout sergey-tihon/FSharp.ProjectScaffold/tree/bug branch.
  2. Execute build generatedocs
  3. You will get HTML docs without code tips.

The only difference of this branch is that it copies Fsharp.Core.dll into build target directory.
As I understand FSharp.Compiler.Services loads Fsharp.Core.dll from build target which was copied without siginfo/optdata and tips generation works incorrectly.

@ghost
Copy link

ghost commented Mar 12, 2014

The version of FSharp.Compiler.Services being used is very old. The problem may still occur, but maybe not. Could you update FSharp.Formatting to 0.0.33, and FSharp.ProjectScaffold to that new version of FSharp.Formatting? fsprojects/FSharp.Formatting#142

@sergey-tihon
Copy link
Contributor Author

I did it. Bug still occur with latest FSharp.Formatting and FSharp.Compiler.Services.
Please try again (the same link)

@ghost
Copy link

ghost commented Mar 12, 2014

This is quite hard to fix without potentially introducing resolution discrepancies between FSharp.Compiler.Service and F# proper.

You can avoid the problem by passing an explicit path reference to FSharp.Core to FSharp.Compiler.Service.

@ghost ghost closed this as completed in 6036cb7 Mar 12, 2014
@ghost
Copy link

ghost commented Mar 12, 2014

There was a fix for this after all

@sergey-tihon
Copy link
Contributor Author

Yay! It is really works!
Thank you!

sergey-tihon added a commit to fsprojects/ProjectScaffold that referenced this issue Mar 12, 2014
…h loads correct version of FSharp.Core.dll (fsharp/fsharp-compiler-docs#38)

Docs generation script was simplified
ghost pushed a commit that referenced this issue Mar 31, 2014
dsyme added a commit to dsyme/FSharp.Compiler.Service that referenced this issue Mar 23, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant