Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tips generation - issue #45 #46

Merged
4 commits merged into from
Jan 24, 2014
Merged

Conversation

sergey-tihon
Copy link
Member

No description provided.

@sergey-tihon
Copy link
Member Author

New logo position
image

@ghost
Copy link

ghost commented Jan 24, 2014

F# library components generally don't need to ship FSharp.Core (F# apps do).

since the scaffold is generally for F# library projects, perhaps it would be better to fail if FSharp.Core is CopyLocal in any project?

@sergey-tihon
Copy link
Member Author

I am agree that we should notify user that it is not desirable case, but I think that better to have a stable document generation procedure that works in any situation.
As an option:
image

@ghost
Copy link

ghost commented Jan 24, 2014

Fine, but change the error message to say "consider setting CopyLocal to false for FSharp.Core in .fsproj files"?

@sergey-tihon
Copy link
Member Author

Done

ghost pushed a commit that referenced this pull request Jan 24, 2014
Fixed tips generation - issue #45
@ghost ghost merged commit dd9abac into fsprojects:master Jan 24, 2014
@ghost
Copy link

ghost commented Jan 24, 2014

Could you also add an issue for FSharp.Compiler.Services to tolerate an FSharp.Core without siginfo/optdata in the search path?

@7sharp9
Copy link
Member

7sharp9 commented Jan 24, 2014

In fsformatting I have seen an issue with razor complaining about multiple FSharp.Core references, maybe thats related to including it as a reference?

@sergey-tihon
Copy link
Member Author

It can be... do you have a link to this issue?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants