New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

series.GetKeyAt and frame.GetRowKeyAt take different types for index. Seems inconsistent. #523

Open

travis-leith opened this issue Nov 16, 2020 · 1 comment

travis-leith commented Nov 16, 2020

series.GetKeyAt takes an index of type int
frame.GetRowKeyAt takes an index of type int64.

Should these not be the same type?

The text was updated successfully, but these errors were encountered:

Contributor

zyzhu commented Feb 21, 2021

int64 came from the Big Deedle prototype @tpetricek experimented back here https://github.com/fslaborg/Deedle/blame/c5c011a176a0989369cc474e9cd9ff2405968b4a/src/Deedle/Indices/Index.fs#L131

On the other hand, int64 address are preserved mostly internal. The public interfaces convert them back to int to keep library from breaking changes during the experiment. Such as this https://github.com/fslaborg/Deedle/blob/master/src/Deedle/Frame.fs#L175

In that sense, it's a separate discussion whether the library shall keep the half-baked Big Deedle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment