Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Started #1

Closed
samjacobson opened this issue Nov 16, 2014 · 8 comments
Closed

Get Started #1

samjacobson opened this issue Nov 16, 2014 · 8 comments

Comments

@samjacobson
Copy link
Contributor

Refer here: howeyc/fsnotify#54

I believe that we can begin with the code I originally contributed to fsnotify, and modify it to suit.

@nathany
Copy link
Contributor

nathany commented Nov 16, 2014

Sounds good to me.

I was thinking it could be a good idea to write unexported wrappers against the various OS X bits and then figure out the exported API from that. Just a thought.

@nathany
Copy link
Contributor

nathany commented Nov 16, 2014

I made a pull request for some (minor) work I did earlier today #2. Mostly reading some of the FSEvents documentation.

I switched the teams around so you have the commit bit on this repo now.

@nathany
Copy link
Contributor

nathany commented Nov 16, 2014

Sadly your day is my night. It's like Ladyhawke.

@samjacobson
Copy link
Contributor Author

Lol. It's actually my afternoon, but the first chance to do any work today.
I'll have a go at getting a rough draft working this evening.

On Sun, Nov 16, 2014 at 3:54 PM, Nathan Youngman notifications@github.com
wrote:

Sadly your day is my night. It's like Ladyhawke
https://en.wikipedia.org/wiki/Ladyhawke.


Reply to this email directly or view it on GitHub
#1 (comment).

@nathany
Copy link
Contributor

nathany commented Nov 16, 2014

Thanks Sam.

Please take a look at Google's CLA too.
https://developers.google.com/open-source/cla/individual

@nathany
Copy link
Contributor

nathany commented Nov 16, 2014

Oh, and feel free to copy INTERNALS.md over here too. I felt like it should be under your name, since you wrote it. It probably will end up needing some revisions, at least the second half.

@pkrnjevic
Copy link

Hi Nathan,

Sorry for the delay getting back to you.
A couple of comments:

  • I hacked together a Go proof of concept using Window USN Journals, functionally equivalent to FSEvents in OS X. It might be useful if you want to support Windows.
  • I could work on a Linux version if someone could point me to equivalent journalling functionality there. Linux fsnotify just isn't up to the job.

@nathany
Copy link
Contributor

nathany commented Nov 16, 2014

Thanks Peter. I moved this discussion to the fsnotify repository. This repo is specific to fsevents on OS X. Better Windows support would be great! Linux, I have no idea if/what there is for journalling.

@nathany nathany closed this as completed Dec 4, 2014
nathany added a commit that referenced this issue Aug 26, 2018
# This is the 1st commit message:

update Travis CI config

travis: update golint location

travis: macOS 10.10

# The commit message #1 will be skipped:

# travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants