Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .net standard 2.0 support #241

Merged
merged 17 commits into from
Oct 9, 2017
Merged

Conversation

enricosada
Copy link
Contributor

@enricosada enricosada commented Oct 4, 2017

remove (for the netstandard2.0 tfm) the api based on projectcracker (old fsproj), because is not supported on netstandard.

the failing test are disabled, with category NetstandardKnownFailure
You can run these with:

dotnet test tests\FSharpLint.Core.Tests.netstandard --filter TestCategory=NetstandardKnownFailure

@enricosada enricosada mentioned this pull request Oct 4, 2017
4 tasks
@enricosada enricosada changed the title [WIP] add .net standard 2..0 support add .net standard 2..0 support Oct 6, 2017
@enricosada enricosada changed the title add .net standard 2..0 support add .net standard 2.0 support Oct 6, 2017
@enricosada
Copy link
Contributor Author

ok @duckmatt ready to review

@duckmatt
Copy link
Collaborator

duckmatt commented Oct 9, 2017

Great, thank you for taking the time to do this :) do you know what causes the NetstandardKnownFailure tests fail?

@duckmatt duckmatt merged commit 51ed783 into fsprojects:master Oct 9, 2017
@enricosada
Copy link
Contributor Author

Nope, sry.
i tried to check a bit, but i am not familiar with this lib, so dunno if real error or just FCS who diverge on stuff

@enricosada
Copy link
Contributor Author

@duckmatt is possibile to have a new release? i'd like to use this with netstandard in ionide/FsAutoComplete#224

atm i am using a dev build and works, but i am near merge :D

@duckmatt
Copy link
Collaborator

Sorry for the slowness, I've released 0.9.0-beta, I'll try to take a look at the excluded tests this weekend to remove the beta tag :)

@ErikSchierboom
Copy link
Contributor

@duckmatt I see that the 0.9.0-beta package is still the latest version. Might I inquire on the progress of the netstandard version?

@duckmatt
Copy link
Collaborator

@ErikSchierboom I have to admit I haven't touched it since. I'm going to try and allocate a bit more of my time back to this project so should be able to release a 0.9.1 with updated dependencies and fixed build in the next week or so

@ErikSchierboom
Copy link
Contributor

@duckmatt Great! Good luck with it.

@jrr jrr mentioned this pull request Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants