Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .net471 for .net standard support #181

Closed
cgravill opened this issue Jul 8, 2018 · 2 comments
Closed

Update to .net471 for .net standard support #181

cgravill opened this issue Jul 8, 2018 · 2 comments

Comments

@cgravill
Copy link
Member

cgravill commented Jul 8, 2018

Description

Some nuget packages aren't being fully referenced such as https://www.nuget.org/packages/Microsoft.ML/

I suspect this is because of the current .net461 target. Can we upgrade to provide wider support?

See https://github.com/Microsoft/AzureNotebooks/issues/409#issuecomment-401530030

@cgravill
Copy link
Member Author

cgravill commented Jul 8, 2018

I have a version mostly working on the branch net471. It needs more testing and some of the helper scripts need to be made framework version-insensitive.

When I actually reference a .netstandard2.0 NuGet it partially works but you need to manually add the reference to .net standard e.g.

#load "Paket.fsx"

Paket.Package [ 
    "Microsoft.ML"
    "NETStandard.Library"]

#r "packages/NETStandard.Library/build/netstandard2.0/ref/netstandard"
#load "Paket.Generated.Refs.fsx"

Longer term this is going to cause people issues when netstandard has a new version. There's a Paket issue tracking being able to discuss adding the required reference:
fsprojects/Paket#3216

@cgravill
Copy link
Member Author

I've merged these changes in so it should be a bit easier to interact with .net standard NuGets. You'll still need the manual #r to netstandard for now and there's further work to be done on getting native library references but that's either a manual operation or Paket may be able to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant