Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivia before bar is being repeated #1083

Closed
3 tasks
nojaf opened this issue Sep 4, 2020 · 0 comments · Fixed by #1086
Closed
3 tasks

Trivia before bar is being repeated #1083

nojaf opened this issue Sep 4, 2020 · 0 comments · Fixed by #1086

Comments

@nojaf
Copy link
Contributor

nojaf commented Sep 4, 2020

Issue created from fantomas-online

Code

Seq.takeWhile
               (function
                         | Write ""
                         // for example:
                         // type Foo =
                         //     static member Bar () = ...
                         | IndentBy _
                         | WriteLine
                         | SetAtColumn _
                         | Write " -> "
                         | CommentOrDefineEvent _ -> true
                         | _ -> false)

Result

Seq.takeWhile (function
    | Write ""
    // for example:
    // type Foo =
    //     static member Bar () = ...
    | IndentBy _
    // for example:
    // type Foo =
    //     static member Bar () = ...
    | WriteLine
    // for example:
    // type Foo =
    //     static member Bar () = ...
    | SetAtColumn _
    // for example:
    // type Foo =
    //     static member Bar () = ...
    | Write " -> "
    // for example:
    // type Foo =
    //     static member Bar () = ...
    | CommentOrDefineEvent _ -> true
    | _ -> false)

Problem description

Similar to #1082, the scope of the bar token should be limited to a single clause.

Extra information

  • The formatted result breaks by code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas Master at 09/03/2020 19:59:28 - 573b009

Default Fantomas configuration

@nojaf nojaf changed the title Trivia before pipe is being repeated Trivia before bar is being repeated Sep 4, 2020
nojaf added a commit to nojaf/fantomas that referenced this issue Sep 4, 2020
nojaf added a commit that referenced this issue Sep 4, 2020
* Limit the range for triva from bar token. Fixes #1083

* Removed unused active pattern
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant