Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idempotency issue with let … in #1608

Closed
3 tasks
Smaug123 opened this issue Apr 6, 2021 · 0 comments · Fixed by #1617
Closed
3 tasks

Idempotency issue with let … in #1608

Smaug123 opened this issue Apr 6, 2021 · 0 comments · Fixed by #1617

Comments

@Smaug123
Copy link
Contributor

Smaug123 commented Apr 6, 2021

Issue created from fantomas-online

Code

module Foo =
    let bar () =

        let rec loop () = async {
            let! msg = thing
            match msg with
            | Message ->
                let passThrough () = ()
                let runStep = baz
                match thing with
                | Boo ->
                    stepLog.LogInformation ("Thing thing thing {Foo} thing", (let (DuCase a) = ThingThingThing.go options |> BlahBlah foo in a))
        }
        ()

Result

module Foo =
    let bar () =

        let rec loop () =
            async {
                let! msg = thing

                match msg with
                | Message ->
                    let passThrough () = ()
                    let runStep = baz

                    match thing with
                    | Boo ->
                        stepLog.LogInformation (
                            "Thing thing thing {Foo} thing",
                            (let (DuCase a) =
                                ThingThingThing.go options |> BlahBlah foo in

                             a)
                        )
            }

        ()

Problem description

This is actually an idempotency issue, but I can't use that button for this because GitHub complains the URI is too long. A reformat adds an extra newline.

Extra information

  • The formatted result breaks by code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas Master at 04/05/2021 16:09:34 - 31922c0

    { config with
                MaxLineLength = 100
                SpaceBeforeUppercaseInvocation = true
                SpaceBeforeClassConstructor = true
                SpaceBeforeMember = true
                SpaceBeforeColon = true
                SpaceBeforeSemicolon = true
                MultilineBlockBracketsOnSameColumn = true
                NewlineBetweenTypeDefinitionAndMembers = true
                KeepIfThenInSameLine = true
                AlignFunctionSignatureToIndentation = true
                AlternativeLongMemberDefinitions = true
                MultiLineLambdaClosingNewline = true
                KeepIndentInBranch = true }

Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?

nojaf added a commit to nojaf/fantomas that referenced this issue Apr 8, 2021
nojaf added a commit that referenced this issue Apr 8, 2021
* Don't determine isInSameLine based on ranges. Fixes #1608.

* Remove temporary test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants