Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idempotency problem when piping just before the keyword in #1610

Closed
3 tasks
Smaug123 opened this issue Apr 6, 2021 · 0 comments · Fixed by #1619
Closed
3 tasks

Idempotency problem when piping just before the keyword in #1610

Smaug123 opened this issue Apr 6, 2021 · 0 comments · Fixed by #1619

Comments

@Smaug123
Copy link
Contributor

Smaug123 commented Apr 6, 2021

Issue created from fantomas-online

Formatted code

module Foo =
    let bar () =

        let f1 = ()

        let runTest () =
            let (Thing f) =
                [ a ; b ] |> Blah.tryConcat |> Option.get in f () |> ignore

        Assert.Throws<exn> runTest |> ignore

Reformatted code

module Foo =
    let bar () =

        let f1 = ()

        let runTest () =
            let (Thing f) =
                [ a ; b ] |> Blah.tryConcat |> Option.get in

            f () |> ignore

        Assert.Throws<exn> runTest |> ignore

Problem description

Fantomas was not able to produce the same code after reformatting the result.

This might be related to #1608, maybe.

Extra information

  • The formatted result breaks by code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas Master at 04/05/2021 16:09:34 - 31922c0

    { config with
                MaxLineLength = 100
                SpaceBeforeUppercaseInvocation = true
                SpaceBeforeClassConstructor = true
                SpaceBeforeMember = true
                SpaceBeforeColon = true
                SpaceBeforeSemicolon = true
                MultilineBlockBracketsOnSameColumn = true
                NewlineBetweenTypeDefinitionAndMembers = true
                KeepIfThenInSameLine = true
                AlignFunctionSignatureToIndentation = true
                AlternativeLongMemberDefinitions = true
                MultiLineLambdaClosingNewline = true
                KeepIndentInBranch = true }

Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?

nojaf added a commit to nojaf/fantomas that referenced this issue Apr 8, 2021
nojaf added a commit that referenced this issue Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants