Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not duplicate comment #1914

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Do not duplicate comment #1914

merged 1 commit into from
Oct 12, 2021

Conversation

su8898
Copy link
Contributor

@su8898 su8898 commented Oct 12, 2021

Fixes #1912

nojaf
nojaf reviewed Oct 12, 2021
View reviewed changes
src/Fantomas.Tests/CommentTests.fs Outdated
@@ -1558,3 +1558,44 @@ Host

//
"""

[<Test>]
let ``comment should not be duplicated, 1912`` () =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you a slightly more related test name?
Something like comment after bracket in record should not be duplicated in computation expression

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@su8898 same for the commit message title, add "in computation expression" at the end at least

nojaf
nojaf reviewed Oct 12, 2021
View reviewed changes
src/Fantomas/CodePrinter.fs Outdated
@@ -1389,6 +1389,7 @@ and genExpr astContext synExpr ctx =
)

| CompExpr (isArrayOrList, e) ->

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this newline, please? Keep the git diff as minimal as possible.

nojaf
nojaf requested changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @su8898, thanks for this PR.
Could you address my two nitpicks, please?

@su8898 su8898 changed the title Do not duplicate comment Do not duplicate comment Oct 12, 2021
@su8898
Copy link
Contributor Author

su8898 commented Oct 12, 2021

Hi @nojaf many thanks for the review. I've addressed the nits. Could you please take a look?

nojaf
nojaf approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @su8898!

@nojaf nojaf merged commit 76167b5 into fsprojects:master Oct 12, 2021
@nojaf nojaf mentioned this pull request Nov 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knocte knocte knocte left review comments

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comment gets duplicated
3 participants
@su8898 @knocte @nojaf