Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Fantomas to Fantomas.Core and fantomas-tool to fantomas #2185

Closed
wants to merge 13 commits into from
Closed

Rename Fantomas to Fantomas.Core and fantomas-tool to fantomas #2185

wants to merge 13 commits into from

Conversation

dawedawe
Copy link
Member

@dawedawe dawedawe commented Apr 3, 2022

Fixes #2174

For the time being, I think it might be better to stay with the current directory names to ease mergers with master.
But in the long run, syncing up logical names with directory names can prevent some confusion.
What's your opinion on this, @nojaf?

josh-degraw and others added 6 commits March 30, 2022 15:07
@josh-degraw @nojaf
Initial settings for strousrup bracket style (fsprojects#2161)
0f86ecd 
* Bare minimal changes for one test case.

* Initial draft of ragnarok feature.

* Add more syntax node where the case occurs.

* Maybe multiline strings?

* Highlight additional cases in SynBinding.

* Add new setting for ragnarok mode.
Take anonymous records in SynBinding into account.

* Separate test case into multiple files. Implement SynBindingFunction and Expressions.

* Add support for computation expressions.

* Add support for Array/List in SynBinding value/function.

* Exclude update records.

* Synbinding function with return type.

* Add additional tests for type members.

* Add LetOrUseBang with Expression.

* Add YieldOrReturn with Expression.

* Add YieldOrReturnBang with Expression.

* Add SynExprAndBang with Expression.

* Format test files.

* Add tests suffix

* Add LongIdentSetExpression with Expression.

* Add DotIndexedSet with Expression.

* Add Set with Expression.

* Add DotSet with Expression.

* Add Lambda with Expression.

* Add SynMatchClause with Expression.

* Add SynTypeDefnSimpleRepr.Record NOTE: TESTS FAIL

* Add SynTypeDefnSigRepr.Simple

* Use correct helper function for Set and DotSet.

* Work around edge case where match clause body needs to be further indented.

* Add named arguments in application and new expressions.

* Fix leftover issue

* Add TODO comment

* Fix failing test

* Format files

Co-authored-by: nojaf <florian.verdonck@outlook.com>
@nojaf
Add changelog entry for first alpha of v5 (fsprojects#2162)
d715f9c
@dawedawe
- Rename Fantomas.fsproj to Fantomas.Core.fsproj
fa9e82d 
- Raname namespaces accordingly
  Fantomas -> Fantomas.Core
  Fantomas.Xyz -> Fantomas.Core.Xyz
@dawedawe
Remove superluous "open Fantomas"
0c56209
@dawedawe
- Rename fantomas-tool to fantomas
722e1de 
- Adjust documentation, scripts and code
@dawedawe
Add entry about renaming to CHANGELOG.md
08b3ce7
@nojaf
Copy link
Contributor

nojaf commented Apr 4, 2022

Hey, thanks for putting this one out.
I think it might be interesting to wait with this one until all the new features and changes are implemented.
Once stroupstrous and the custom compiler are merged in, we could revisit this PR.

nojaf
nojaf requested changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for now.

josh-degraw and others added 4 commits April 4, 2022 16:23
@josh-degraw @nojaf
Initial settings for strousrup bracket style (fsprojects#2161)
f28db6d 
* Bare minimal changes for one test case.

* Initial draft of ragnarok feature.

* Add more syntax node where the case occurs.

* Maybe multiline strings?

* Highlight additional cases in SynBinding.

* Add new setting for ragnarok mode.
Take anonymous records in SynBinding into account.

* Separate test case into multiple files. Implement SynBindingFunction and Expressions.

* Add support for computation expressions.

* Add support for Array/List in SynBinding value/function.

* Exclude update records.

* Synbinding function with return type.

* Add additional tests for type members.

* Add LetOrUseBang with Expression.

* Add YieldOrReturn with Expression.

* Add YieldOrReturnBang with Expression.

* Add SynExprAndBang with Expression.

* Format test files.

* Add tests suffix

* Add LongIdentSetExpression with Expression.

* Add DotIndexedSet with Expression.

* Add Set with Expression.

* Add DotSet with Expression.

* Add Lambda with Expression.

* Add SynMatchClause with Expression.

* Add SynTypeDefnSimpleRepr.Record NOTE: TESTS FAIL

* Add SynTypeDefnSigRepr.Simple

* Use correct helper function for Set and DotSet.

* Work around edge case where match clause body needs to be further indented.

* Add named arguments in application and new expressions.

* Fix leftover issue

* Add TODO comment

* Fix failing test

* Format files

Co-authored-by: nojaf <florian.verdonck@outlook.com>
@nojaf
Add changelog entry for first alpha of v5 (fsprojects#2162)
9e53661
@dawedawe @josh-degraw @nojaf
Update TargetFramework of .NET tool to net6.0 (fsprojects#2184)
3f5c6ad 
* Initial settings for strousrup bracket style (fsprojects#2161)

* Bare minimal changes for one test case.

* Initial draft of ragnarok feature.

* Add more syntax node where the case occurs.

* Maybe multiline strings?

* Highlight additional cases in SynBinding.

* Add new setting for ragnarok mode.
Take anonymous records in SynBinding into account.

* Separate test case into multiple files. Implement SynBindingFunction and Expressions.

* Add support for computation expressions.

* Add support for Array/List in SynBinding value/function.

* Exclude update records.

* Synbinding function with return type.

* Add additional tests for type members.

* Add LetOrUseBang with Expression.

* Add YieldOrReturn with Expression.

* Add YieldOrReturnBang with Expression.

* Add SynExprAndBang with Expression.

* Format test files.

* Add tests suffix

* Add LongIdentSetExpression with Expression.

* Add DotIndexedSet with Expression.

* Add Set with Expression.

* Add DotSet with Expression.

* Add Lambda with Expression.

* Add SynMatchClause with Expression.

* Add SynTypeDefnSimpleRepr.Record NOTE: TESTS FAIL

* Add SynTypeDefnSigRepr.Simple

* Use correct helper function for Set and DotSet.

* Work around edge case where match clause body needs to be further indented.

* Add named arguments in application and new expressions.

* Fix leftover issue

* Add TODO comment

* Fix failing test

* Format files

Co-authored-by: nojaf <florian.verdonck@outlook.com>

* Add changelog entry for first alpha of v5 (fsprojects#2162)

* - Update TargetFramework of .NET tool to net6.0
- Adjust path in TestHelpers.fs

* Add CHANGELOG.md entry

* move changelog entry to Unreleased section

* Fix CHANGELOG.md

Co-authored-by: Josh DeGraw <18509575+josh-degraw@users.noreply.github.com>
Co-authored-by: nojaf <florian.verdonck@outlook.com>
@nojaf
Add release notes for 5.0.0-alpha-002
0cb86a7
@nojaf nojaf force-pushed the get-back branch 3 times, most recently from 4314b57 to 7e615c2 Compare May 6, 2022 06:13
@nojaf
Copy link
Contributor

nojaf commented May 6, 2022

Hey @dawedawe, I'll have the same amount of work applying these changes in a new branch as I would if I were to rebase this. I'll create a new PR inspired by this instead.

This was referenced May 6, 2022
Merged
Merged
@nojaf nojaf closed this May 6, 2022
@dawedawe dawedawe deleted the fix-2174 branch August 25, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dawedawe @nojaf @josh-degraw @reijerh