Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark config as optional in public API. #2350

Merged
merged 4 commits into from
Jul 8, 2022

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Jul 8, 2022

The main motivation for this is the FormatASTAsync function, which is used primarily by projects that generate code. They do not have any source input and typically don't care about the output so use they use the default configuration.

Copy link
Member

@dawedawe dawedawe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nojaf nojaf merged commit 2350b03 into fsprojects:master Jul 8, 2022
@nojaf nojaf deleted the optional-parameter branch July 8, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants