EndsWithSingleListApp & EndsWithDualListApp are enable by IsStroustrupStyle as well. #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mentalElmish or IsStroustrupStyle.
nojaf
force-pushed
the
experimental-elmish
branch
from
9b97fc0
to
b78c5a5
Compare
josh-degraw
reviewed
Mar 17, 2023
| @@ -227,7 +227,7 @@ type FormatConfig = | |||
|
|
|||
| [<Category("Convention")>] | |||
| [<DisplayName("Applies the Stroustrup style to the final (two) array or list argument(s) in a function application")>] | |||
There was a problem hiding this comment.
Not sure either way, but should we change anything about this displayName to mention elmish or do you think it's fine to stay as is?
There was a problem hiding this comment.
I think this is fine for now. We can revisit this later.
Little secret, but somebody is actually doing anything with these attributes anyway.
We expose them via Fantomas.Client so IDEs can request them but none of them has implemented this.
josh-degraw
approved these changes
Mar 17, 2023
nojaf
added a commit
that referenced
this pull request
Mar 17, 2023
…pStyle as well. (#2795) * EndsWithSingleListApp & EndsWithDualListApp are enbled by both ExperimentalElmish or IsStroustrupStyle. * Renamed test file.
nojaf
added a commit
that referenced
this pull request
Mar 27, 2023
…pStyle as well. (#2795) * EndsWithSingleListApp & EndsWithDualListApp are enbled by both ExperimentalElmish or IsStroustrupStyle. * Renamed test file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @josh-degraw.