Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect to ADLS Gen2 using Service Principal #75

Closed
pedrosanchezr opened this issue Jul 14, 2020 · 1 comment
Closed

Connect to ADLS Gen2 using Service Principal #75

pedrosanchezr opened this issue Jul 14, 2020 · 1 comment

Comments

@pedrosanchezr
Copy link

Hi,

I'm starting using Dask and I wanted to connecto to ADLS Gen2.
I was not finding any way to do it using a service principal and checking the code I see something that I'm not sure if make sense.

In the condition of line 324 of core.py, we are calling "self._get_token_from_service_principal()" if we don't have certain values, but one of those values is the "client_id", which seems to be required later inside that method to generate the credentials. So I guess that if I include the client_id, this is not going to call "self._get_token_from_service_principal()" and if I do not include it, I won't have the right one when it tries to create the "ServicePrincipalCredentials".

Is this ok? How can I use it correctly?

https://github.com/dask/adlfs/blob/c91106fbe9184e7c75efbc40cf292a7d5b8c8491/adlfs/core.py#L324

@hayesgb
Copy link
Collaborator

hayesgb commented Aug 2, 2020

Fixed in adlfs 0.3.2, with supporting documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants