Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Tilde-expansion in write.fst #35

Closed
HughParsonage opened this issue Mar 7, 2017 · 1 comment
Closed

[Feature request] Tilde-expansion in write.fst #35

HughParsonage opened this issue Mar 7, 2017 · 1 comment

Comments

@HughParsonage
Copy link
Contributor

Is it possible to support tilde expansion in read and write.fst? I find that write.fst doesn't support it at all, but read.fst does sporadically. I haven't been able to reproduce an instance of it not working

library(fst)
stopifnot(dir.exists("~/sandbox"))

z <- as.data.frame(x = 1)
write.fst(z, "~/sandbox/z.fst")

Error in fstStore(path, x, as.integer(compress)) :
There was an error creating the file. Please check for a correct filename.

write.fst(z, file.path(path.expand("~"), "sandbox", "z.fst")) # Works

zz <- read.fst("~/sandbox/z.fst") # Works
@MarcusKlik
Copy link
Collaborator

Hi @HughParsonage, thanks for the feature request! I will apply normalizePath to the path variable before passing it to the C++ code which should enable the use of ~ in the path.

@MarcusKlik MarcusKlik self-assigned this Mar 8, 2017
@MarcusKlik MarcusKlik added this to the Fst package v0.8.0 milestone Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants