Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitignore for portfolio #88

Closed
radl97 opened this issue Feb 1, 2021 · 3 comments
Closed

Gitignore for portfolio #88

radl97 opened this issue Feb 1, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@radl97
Copy link
Contributor

radl97 commented Feb 1, 2021

Executing Portfolio test created a file that is not ignored by git.

It seems that the file test/portfolio/0 is supposed to be a logfile of some kind. Maybe this file is created in test/portfolio/ instead of inside test/portfolio/Output?

@AdamZsofi
Copy link
Member

AdamZsofi commented Feb 1, 2021

I saw that 0 before a few times, but I thought it disappeared with another small fix.
Can you share the command (or one of the commands) used?
I'll try to reproduce the problem and take a look at it.

@radl97
Copy link
Contributor Author

radl97 commented Feb 1, 2021

I just ran make check-functional and then it showed up in git status.
Working in master branch, even tested with GAZER_TOOLS_DIR=$PWD/build/tools/ lit test/portfolio/.

Note: The test fails for me, probably because LLVM9 was not properly installed, maybe that triggers the bug.

EDIT: grammar

@radl97 radl97 added the bug Something isn't working label Feb 3, 2021
@AdamZsofi
Copy link
Member

AdamZsofi commented Feb 5, 2021

There was a typo, when creating the logfile (I tried blaming perl-tidy for it, but I couldn't reproduce the thing, so it was probably my fault), which instead of concatenating the filename, tried to divide two strings, but instead of dying it returned 0.

Patched it on the branch portfolio-patch, but there is a good chance, that I'll need to patch a few other things in the coming days, so I'll merge and close this afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants