Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About weight_cross_entropy #3

Closed
terryoo opened this issue Jul 2, 2021 · 1 comment
Closed

About weight_cross_entropy #3

terryoo opened this issue Jul 2, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@terryoo
Copy link

terryoo commented Jul 2, 2021

This paper is quite impressive research.

I have a question about implementation.

In this paper, weight cross-entropy (Content-Aware Module) is employed for calculating loss between the prediction of SR image and gt. However, the code seems to calculate loss between the prediction of HR image and gt.

recognition_loss = weight_cross_entropy(hr_pred, text_gt)

@JingyeChen
Copy link
Member

:D Thank you for pointing out this problem.
We reconstruct the code after this paper was accepted, but have not tested the code since it is a little bit busy these days. I have fixed that problem :D

@JingyeChen JingyeChen added the bug Something isn't working label Jul 24, 2021
@terryoo terryoo closed this as completed Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants