Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension 'forgets' what it just connected as soon as the url changes #10

Closed
fuddl opened this issue Dec 31, 2020 · 1 comment
Closed

Comments

@fuddl
Copy link
Owner

fuddl commented Dec 31, 2020

Steps to reproduce

  1. open a thing not yet connected to wikidata and connect it
    Screen Shot 2020-12-31 at 12 18 10
  2. immediately after that, open a site, that should be connected to the same wikidata entity (i.e. on imdb open the Cast and Credts section)
    Screen Shot 2020-12-31 at 12 18 42

Expected result

The extension should remember that the thing we have just connected since the website we have open now, also has the same id in its url:
Screen Shot 2020-12-31 at 12 22 56

Actual result

The extension has never seen that url before and thus does not know which Wikidata entity is associated to it, and the Wikidata api does not distribute that information yet.
Screen Shot 2020-12-31 at 12 18 47

Possible Solution

Add an additional layer of caching that does not only consider the current url but also the extracted id of the current url.

@fuddl
Copy link
Owner Author

fuddl commented Jan 17, 2021

  • switch to a different tab, that can be resolved to an identifier or item and switch back
  • close the wd4ff sidebar and open it again
  • change to URL in a meaningless way, e.g. adding a parameter not used by the web server and that does not break the regular expression based identifier matching

@fuddl fuddl closed this as completed Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant