Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

Separate block header verifier #15

Closed
adlerjohn opened this issue Jul 8, 2020 · 1 comment
Closed

Separate block header verifier #15

adlerjohn opened this issue Jul 8, 2020 · 1 comment
Assignees
@SilentCicero
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@adlerjohn
Copy link
Contributor

adlerjohn commented Jul 8, 2020 •
edited
Loading

The block header verifier should be split up into a block header verify and root header verifier, instead of lumping them together.
@adlerjohn adlerjohn added bug Something isn't working enhancement New feature or request labels Jul 8, 2020
@SilentCicero
Copy link
Member

Verifying roots in this case does need the blockHeader data (to check root existence) so I'd say I'm fine with leaving the existing function as it.

However would could rename the file for consistency to Header.yulp instead of BlockHeader.yulp for clarity.

@adlerjohn adlerjohn added wontfix This will not be worked on and removed bug Something isn't working labels Jul 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SilentCicero SilentCicero

Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adlerjohn @SilentCicero