You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In fuels-core/src/types/wrappers/transaction_response.rs
let transaction = match client_response.transaction {
Transaction::Script(tx) => TransactionType::Script(ScriptTransaction::from(tx)),
Transaction::Create(tx) => TransactionType::Create(CreateTransaction::from(tx)),
Transaction::Mint(_) => unimplemented!(),
};
unimplemented!() will cause the entire function to panic, None should be returned instead.
The text was updated successfully, but these errors were encountered:
segfault-magnet
changed the title
Transaction Response should be Optional since Mint is not implemented.
Cannot fetch Mint transactions through Provider
Nov 14, 2023
closes#1199
Mint transactions can now be fetched through the `Provider`. Implemented
what made sense for `Mint`, left the rest as `unimplemented!`. Without
some hefty redesign don't see what other option is there but to violate
the LSP (L for Liskov).
Decided to wrap `Mint`, so that users may extract the id, outputs, etc,
without having to know about the various traits from fuel.
### Checklist
- [x] I have linked to any relevant issues.
- [ ] I have updated the documentation.
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added necessary labels.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
In
fuels-core/src/types/wrappers/transaction_response.rs
unimplemented!()
will cause the entire function to panic,None
should be returned instead.The text was updated successfully, but these errors were encountered: