Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove locale #8

Merged
merged 2 commits into from
Jun 20, 2023
Merged

feat: remove locale #8

merged 2 commits into from
Jun 20, 2023

Conversation

fuentesloic
Copy link
Collaborator

Removing locale as useless in this plugin

@fuentesloic fuentesloic requested a review from flozero June 20, 2023 12:44
@fuentesloic fuentesloic self-assigned this Jun 20, 2023
@fuentesloic fuentesloic changed the title chore: remove locale feat: remove locale Jun 20, 2023
@flozero
Copy link
Owner

flozero commented Jun 20, 2023

When you say useless do you mean the user will never have to change it ? Otherwise it could be a good config to have no ?

@fuentesloic
Copy link
Collaborator Author

When you say useless do you mean the user will never have to change it ? Otherwise it could be a good config to have no ?

@flozero the only area they will use it is on client side when opening the Stripe payment page. As it's client side, I think our module users will do it themselves. It's not really a part of stripe.js configuration. Only a params in a specific area of their endpoint

Copy link
Owner

@flozero flozero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright sounds good

@fuentesloic fuentesloic merged commit 96956a3 into main Jun 20, 2023
@fuentesloic fuentesloic deleted the feat/locale-removal branch June 20, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants