Fix lock-order-inversion (potential deadlock) (ros2#1135)

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
fujitatomoya · May 28, 2020 · 31d1db5 · 31d1db5
1 parent 863970e
commit 31d1db5
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/rclcpp/src/rclcpp/node_interfaces/node_graph.cpp b/rclcpp/src/rclcpp/node_interfaces/node_graph.cpp
@@ -321,9 +321,11 @@ rclcpp::Event::SharedPtr
 NodeGraph::get_graph_event()
 {
   auto event = rclcpp::Event::make_shared();
-  std::lock_guard<std::mutex> graph_changed_lock(graph_mutex_);
-  graph_events_.push_back(event);
-  graph_users_count_++;
+  {
+    std::lock_guard<std::mutex> graph_changed_lock(graph_mutex_);
+    graph_events_.push_back(event);
+    graph_users_count_++;
+  }
   // on first call, add node to graph_listener_
   if (should_add_to_graph_listener_.exchange(false)) {
     graph_listener_->add_node(this);