Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coordinate conversion for BEDPE files #40

Merged
merged 4 commits into from
May 10, 2024
Merged

Fix coordinate conversion for BEDPE files #40

merged 4 commits into from
May 10, 2024

Conversation

clintval
Copy link
Member

@clintval clintval commented May 9, 2024 •
edited
Loading

I made a mistake and thought the coordinate system used here was 0-based.

It is 1-based! I've also added this clarification to the docs so others will benefit.

@clintval clintval requested review from nh13 and ameynert May 9, 2024 22:55
@clintval clintval mentioned this pull request May 9, 2024
Merged
ameynert
ameynert approved these changes May 10, 2024
View reviewed changes
Copy link

@ameynert ameynert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

nh13
nh13 reviewed May 10, 2024
View reviewed changes
Copy link
Member

@nh13 nh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq about the coordinate system being 1-based inclusive. Perhaps we should say that somewhere prominent (readme?)

src/main/scala/com/fulcrumgenomics/sv/tools/AggregateSvPileup.scala Outdated Show resolved Hide resolved
@clintval
Copy link
Member Author

qq about the coordinate system being 1-based inclusive. Perhaps we should say that somewhere prominent (readme?)

Good idea. I'll add this as as sub-task to #34

@clintval clintval merged commit fbd4861 into main May 10, 2024
2 checks passed
@clintval clintval deleted the cv_fix_coordinate_system branch May 10, 2024 19:20
@clintval clintval mentioned this pull request May 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh13 nh13 nh13 left review comments

@ameynert ameynert ameynert approved these changes

Assignees

@nh13 nh13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clintval @nh13 @ameynert