Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding hold and deploy steps to CI workflow #21

merged 5 commits into from Nov 6, 2019
Changes from 4 commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.


Just for now

@@ -1,3 +1,8 @@
masterBranchOnly: &masterBranchOnly
only: "master"

version: 2.1
@@ -15,7 +20,6 @@ jobs:
- run:
name: Install
command: npm ci && (cd .github/actions/sync-snippet-action && npm ci)

- save_cache:
- node_modules
@@ -27,6 +31,9 @@ jobs:
- run:
name: Test
command: npm test
- run:
name: Build
command: npm run build
- persist_to_workspace:
root: .
paths: .
@@ -46,9 +53,12 @@ workflows:
- build-browser-sdk
# - deploy-browser-sdk:
# requires:
# - build-browser-sdk
# filters:
# branches:
# only: "master"
- hold:
type: approval
- build-browser-sdk
<<: *masterBranchOnly
- deploy-browser-sdk:
- hold
<<: *masterBranchOnly

This comment has been minimized.

Copy link

sgmitchell Nov 5, 2019

nit: requiring hold which only runs on master should make this redundant

This comment has been minimized.

Copy link

patrick-fs Nov 6, 2019

Author Member

good call. Fixed

@@ -19,7 +19,7 @@ import App from './App';
import FullStory from 'TBD/package-to-be-deployed';
FullStory.init('<your org id here>');
FullStory.init({ orgId: '<your org id here>' });

This comment has been minimized.

Copy link

patrick-fs Nov 5, 2019

Author Member

This is just a quick README fixup I'm sneaking in with the PR. It's not germane to the CI updates.

ReactDOM.render(<App />, document.getElementById('root'));
@@ -14,8 +14,7 @@
"test": "npm run lint && npm run test:karma",
"test:karma": "karma start --single-run --browsers ChromeHeadless karma.conf.js",
"lint": "eslint src test .github/actions",
"build": "tsc src/index.d.ts && rollup -c",
"prepublishOnly": "npm run clean && npm run test && npm run build"
"build": "tsc src/index.d.ts && rollup -c"
"files": [
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.