Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Typescript 5.0 #29

Closed
floscher opened this issue Mar 24, 2023 · 2 comments
Closed

Upgrade to Typescript 5.0 #29

floscher opened this issue Mar 24, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@floscher
Copy link
Contributor

https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/

56047e0

@floscher
Copy link
Contributor Author

floscher commented Apr 4, 2023

@thooyork This leads to an error in the client when npm install is being run and it is updated from 1.3.8 to 1.3.11:

"vue-tsc": "^1.3.0"

https://github.com/fumiX/fuBlog/blob/2cde5d62115453d2534688377c7d8b9258992d20/package-lock.json#L14265-L14280

The error message was something similar to vuejs/language-tools#2570 . It complained about this line, that the value had a type that is not allowed:

<RouterView :userPermissions="userPermissions" />

To reproduce do this to v0.1.0:

rm -r node_modules/ */node_modules/ package-lock.json && npm install && npm run build

Results in this error:

src/App.vue(46,19): error TS2345: Argument of type '{ [x: string]: any; userPermissions: { canEditUserRoles: boolean; canCreatePost: boolean; canEditPost: boolean; canDeletePost: boolean; } | null; }' is not assignable to parameter of type 'AllowedComponentProps & ComponentCustomProps & VNodeProps & RouterViewProps'.
         Object literal may only specify known properties, and 'userPermissions' does not exist in type 'AllowedComponentProps & ComponentCustomProps & VNodeProps & RouterViewProps'.
       src/views/PostFormView.vue(85,34): error TS2339: Property 'dropzoneHighlight' does not exist on type '{ default(): any; }'.
       src/views/PostFormView.vue(88,42): error TS2339: Property 'dropzoneHighlight' does not exist on type '{ default(): any; }'.

@thooyork thooyork self-assigned this Apr 24, 2023
@thooyork thooyork added the enhancement New feature or request label Apr 24, 2023
@thooyork
Copy link
Contributor

thooyork commented May 9, 2023

implemented.

@thooyork thooyork closed this as completed May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants