Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Each child in a list should have a unique "key" props #5

Closed
fonghou opened this issue Apr 9, 2022 · 4 comments
Closed

Each child in a list should have a unique "key" props #5

fonghou opened this issue Apr 9, 2022 · 4 comments

Comments

@fonghou
Copy link

fonghou commented Apr 9, 2022

Hi,

Since updating 2022.04.08-137, I start seeing Each child in a list should have a unique "key" props warnings in React dev build, downgrading to 2022.03.31-133 made it go away.

This may not be a rumext issue, rather than a side effect of upgrading to React 18 (or JSX runtime). However, it's bit strange that the warning message even showed up for components that do not use <li> elements. Is this expected?

thanks for the great library btw!

@niwinz
Copy link
Member

niwinz commented Apr 9, 2022

yeah, i have noticed it also, the latest releases are not pretty stable, and we are experimenting on upgrading to react;
I will notice here about the progress

@niwinz
Copy link
Member

niwinz commented Apr 9, 2022

there are something wrong with current approach jsx, and I will fix it soon.

Previously we have used the jsx production runtime (without warnings) on PROD and DEV builds, so some warnings are expected. But you are right that right now the warnings does not make sense in many cases...

@niwinz
Copy link
Member

niwinz commented Apr 9, 2022

new release uploaded to clojars 2022.04.10-141 that should fix the warnings, still does not tested on penpot codebase.
Additionally, right now we have some runtime checks for children prop being array or not, but I think this can be done on compile time at hikada so I expected to release more versions for optimize this part.

@niwinz niwinz closed this as completed Apr 9, 2022
@niwinz niwinz reopened this Apr 9, 2022
@niwinz niwinz closed this as completed Apr 9, 2022
@niwinz
Copy link
Member

niwinz commented Apr 9, 2022

If you still experimenting some unusual warnings, please reopen this issue.
If you have other issues related to react-18 update, please open a separate issue

Thanks for the feedback in any case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants