New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atomic file write: does not sync #27

Closed

joonas-fi opened this issue Sep 17, 2024 · 1 comment

Labels

bug

Member

joonas-fi commented Sep 17, 2024 •

edited

Loading

It does Close() and Rename(), but NOT Sync() before close. Apparently Close() does not guarantee buffers hit the disk:

A successful close does not guarantee that the data has been successfully saved to disk, as the kernel defers writes. It is not common for a file system to flush the buffers when the stream is closed. If you need to be sure that the data is physically stored use fsync(2).

Source: close() syscall documentation

The (2) is a user-hostile way to abbreviate "(system call)"

The text was updated successfully, but these errors were encountered:

joonas-fi added the bug label

Member Author

joonas-fi commented Oct 8, 2024

Tailscale also uses .Sync() in their mini-library: tailscale/tailscale@bcbd411

joonas-fi closed this as completed in

168ace4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment