Print Swarm Listen On #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitaaron
approved these changes
Jun 21, 2022
apps/box/src/utils.ts
Outdated
| for (const localip of ips) { | ||
| console.log(`Swarm listening on ${ma.toString().replace('0.0.0.0', localip)}/p2p/${peerId.toB58String()}`)} | ||
| } else { | ||
| console.log(`Swarm listening on ${ma.toString()}/p2p/${peerId.toB58String()}`) |
There was a problem hiding this comment.
'swarm' could mean many things - perhaps we should just use the name of the application listening? 'Box listening on...'
There was a problem hiding this comment.
Oh I just mimic the js-ipfs. We can change it.
|
Yes my concern is it may get mixed up with ipfs. Thanks 👍
…On Tue., Jun. 21, 2022, 10:30 a.m. Farhoud, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In apps/box/src/utils.ts
<#228 (comment)>:
> + // 'IPv4' is in Node <= 17, from 18 it's a number 4 or 6
+ const familyV4Value = typeof net.family === 'string' ? 'IPv4' : 4
+ if (net.family === familyV4Value && !net.internal) {
+ if (net.address)
+ ips.push(net.address);
+ }
+ }
+}
+
+export const printSwarm = (peerId, multiaddrs) => {
+ for (const ma of multiaddrs) {
+ if (ma.toString().includes('0.0.0.0')) {
+ for (const localip of ips) {
+ console.log(`Swarm listening on ${ma.toString().replace('0.0.0.0', localip)}/p2p/${peerId.toB58String()}`)}
+ } else {
+ console.log(`Swarm listening on ${ma.toString()}/p2p/${peerId.toB58String()}`)
Oh I just mimic the js-ipfs. We can change it.
—
Reply to this email directly, view it on GitHub
<#228 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFDZ3ILKST37FM3NUSZJLVQHGYDANCNFSM5ZL73Z3A>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
- Fix Message and naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #225