Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental versioning could be incorrect #10

Closed
novoselov-ab opened this issue Apr 3, 2018 · 2 comments
Closed

Incremental versioning could be incorrect #10

novoselov-ab opened this issue Apr 3, 2018 · 2 comments

Comments

@novoselov-ab
Copy link

While reading the code I think I found an issue, but I am not sure, apologize in advance in that case :)

It could happen that you loaded new version, failed, rollback happened. Later you again update the plugin, version increments and it will start to load on the same version as was already tried once. But since dll was once loaded VS will lock .dll/.pdb files and you won't be able to overwrite them. So it looks like it would be better to always try newer version (the one which was never ever loaded with LoadLibrary).

@fungos
Copy link
Owner

fungos commented Apr 3, 2018

I believe I'd tested this case on a Visual Studio debugging session but I'm not sure as it was some time ago. I will let this issue open until I have the time to check it again.

Thank you for reviewing the code, btw!

@fungos
Copy link
Owner

fungos commented Nov 14, 2018

Tried and could not reproduce, but also I did some fixes recently that may have fixed this.

@fungos fungos closed this as completed Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants