Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1. Update rules -> 3.9 #97

Merged
merged 2 commits into from
Feb 15, 2023
Merged

1. Update rules -> 3.9 #97

merged 2 commits into from
Feb 15, 2023

Conversation

RobertMili
Copy link
Contributor

  1. adding maven-deploy-plugin 3.0.0
  2. adding maven-site-plugin 4.0.0M
  3. adding extra new line on the end
  4. removed second compiler plugin
  5. Fixing conflict with main branch
  6. Delete two file
  7. Change maven version to 3.8.1
  8. Ignoring *.impl files in target.
  9. Removing haze.iml folder
  10. squash commits

@RobertMili RobertMili linked an issue Feb 13, 2023 that may be closed by this pull request
Update Maven plugin versions #7
Closed
safstromo
safstromo previously approved these changes Feb 13, 2023
View reviewed changes
Anton20HD
Anton20HD previously approved these changes Feb 13, 2023
View reviewed changes
@RobertMili RobertMili mentioned this pull request Feb 13, 2023
Closed
kappsegla
kappsegla requested changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@kappsegla kappsegla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the README.md file looks like they are a duplication of already existing lines? I suggest that these changes are removed, so only changes to .gitignore and pom.xml remains.

safstromo
safstromo previously approved these changes Feb 14, 2023
View reviewed changes
Anton20HD
Anton20HD previously approved these changes Feb 14, 2023
View reviewed changes
@RobertMili RobertMili dismissed stale reviews from Anton20HD and safstromo via 75725dd February 14, 2023 14:17
@RobertMili RobertMili force-pushed the 7-update-maven-plugin-versions-with-verfied-account branch from 54024e5 to 75725dd Compare February 14, 2023 14:17
safstromo
safstromo previously approved these changes Feb 14, 2023
View reviewed changes
kappsegla
kappsegla requested changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@kappsegla kappsegla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pom.xml looks good. Tried running mvn clean verify with included IT tests and all seams to run as expected.

.gitignore Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Feb 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

kappsegla
kappsegla approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@kappsegla kappsegla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfekt! I think this PR is ready to be merged first thing tomorrow.

@RobertMili RobertMili added this pull request to the merge queue Feb 15, 2023
Merged via the queue into main with commit 71161d5 Feb 15, 2023
@kappsegla kappsegla deleted the 7-update-maven-plugin-versions-with-verfied-account branch February 15, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kappsegla kappsegla kappsegla approved these changes

@Henrik-Bengtsson Henrik-Bengtsson Henrik-Bengtsson approved these changes

@Anton20HD Anton20HD Anton20HD approved these changes

@jLereback jLereback Awaiting requested review from jLereback

@safstromo safstromo Awaiting requested review from safstromo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Maven plugin versions
5 participants
@RobertMili @kappsegla @safstromo @Henrik-Bengtsson @Anton20HD